Remove SSR folder from source control #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you get this error after running the ssr command? @JoeyMckenzie @tnylea |
|
@rahmat-dev Yeah, I noticed that last night. Working to fix that now, just need to adjust the JS execution context for SSR in some scenarios (like the theme toggle that caused that error). Work in progress. |
JoeyMckenzie
added a commit
to JoeyMckenzie/laravel-official-react-starter-kit
that referenced
this pull request
Mar 2, 2025
* chore: add ssr folder to gitignore * Update .gitignore --------- Co-authored-by: Taylor Otwell <[email protected]>
lucianodigital2b
referenced
this pull request
in lucianodigital2b/clevernote
Jul 1, 2025
* chore: add ssr folder to gitignore * Update .gitignore --------- Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great work with these kits! One minor thing, looks like the
bootstrap/ssrfolder isn't being ignored by source control. Added that folder to the.gitignorefile to fix that.Same change can be found in the Vue starter kit as well.